Add read_buf equivalents for positioned reads
#140459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
This comment has been minimized.
This comment has been minimized.
niklasf
force-pushed
the
feature/read-buf-at
branch
from
74e016c to
2ccb45f
Compare
|
Have these changes been discussed with libs-api at all? Usually changes to unstable API need to be proposed at https://github.com/rust-lang/libs-team/ with the ACP issue template. This needs some tests as well. |
|
For the above, |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
For consistency and clarity, could we include safety comments on each unsafe block? Even brief notes are helpful to understand the assumptions being made |
niklasf
force-pushed
the
feature/read-buf-at
branch
from
2ccb45f to
09ac65a
Compare
This comment has been minimized.
This comment has been minimized.
niklasf
force-pushed
the
feature/read-buf-at
branch
from
09ac65a to
a22d2b4
Compare
This comment has been minimized.
This comment has been minimized.
niklasf
force-pushed
the
feature/read-buf-at
branch
from
a22d2b4 to
59cb58e
Compare
This comment has been minimized.
This comment has been minimized.
Adds the following items under the `read_buf_at` (rust-lang#140771) feature: - `std::os::unix::FileExt::read_buf_at` - `std::os::unix::FileExt::read_buf_exact_at` - `std::os::windows::FileExt::seek_read_buf`
niklasf
force-pushed
the
feature/read-buf-at
branch
from
59cb58e to
85e1da1
Compare
|
Thank you both.
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following items under the
read_buf(#78485)read_buf_at(#140771) feature:std::os::unix::fs::FileExt::read_buf_atstd::os::unix::fs::FileExt::read_buf_exact_atstd::os::windows::fs::FileExt::seek_read_buf